Promise, Async, Await - Boolean Returns False But If Condition Still Gets Called

Context I have this piece of code to force app update, that checks whether an update is needed and is supposed to return true or false depending on the version number of the user's

Solution 1:

I wonder how TypeScript hasn't caught this, but the problem is that your function returns a Promise<void> instead of a Promise<boolean>. You never return anything from isLatestVersion, so it ends up with undefined, and your inverted condition always runs the if block.

The underlying issue is with awaiting a .then(…) chain - you want to use either then and return:

const isLatestVersion = (): Promise<boolean> => {
//                     ^ no asyncreturnVersionCheck.needUpdate({
//^^^^^^packageName: 'com.greenshield.mobileclaims',
  }).then((res) => {
    console.log(res)
    return res.isNeeded
  })
}

or only await:

const isLatestVersion = async (): Promise<boolean> => {
  const res = awaitVersionCheck.needUpdate({
//            ^^^^^packageName: 'com.greenshield.mobileclaims',
  });
//  ^ no .then()console.log(res)
  return res.isNeeded
}