Array Returning Indexof Rather Than Count Of Pattern

So I've edited my code a bit and I'm stuck trying to the count the number of times a pattern occurs in a specified record. I would like the array to return as 2,1,0 if something li

Solution 1:

You need to be keeping the count, not the index at which it was found in result. You should increment the count only if the index is greater than or equal to zero. Note I've made a few optimizations as well to reduce the number of times you need to transform the strings. I've also added a different version that uses regular expressions.

functioncount(books, pattern) {
    var result = [];
    for (i = 0; i < books.length; i++) {
        var index = -1, // set to -1 so that the first iteration will set it to 0
            title = books[i].title.toLowerCase(),
            realPattern = pattern.toLowerCase();
        result[i] = 0;
        do {
            index = title.indexOf(pattern, index + 1);
            if (index >= 0) {
               result[i] = result[i] + 1;
            }
        }
        while (index >= 0)
    }
    return result;
}

Better alternative

RegExp.escape = function(text) {
    return text.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, "\\$&");
}

functioncount(books, pattern) {
    var result = [];
    for (i = 0; i < books.length; i++) {
        var regex = newRegExp(RegExp.escape(pattern),'gi'),
            matches = books[i].title.match(regex);
        result[i] = matches ? matches.length : 0;
    }
    return result;
}

Solution 2:

You can use a for in loop and push the loop var into your results variable.

jsfiddle

var arr = ['a', 'b', 'c', 'a'];

functioncount(books, pattern) {   
    var results = [];
    for (var index in arr) {
        if (arr[index] === pattern) {
          results.push(index);
        } 
    }
    return results;
}

console.log(count(arr, 'a'));

Solution 3:

Try this it's very simple:

functioncount(books, pattern) 
{

var num = 0;
var result = Array();
for (i = 0; i < books.length; i++) 
{
    var times = books[i].title.toLowerCase().split(pattern.toLowerCase());
    if(times.length - 1 >= 0)result[i] = times.length - 1;
}
return result;
}

Hope you'll find this usefull!

Solution 4:

You could simplify your code a lot by using match. I made a jsfiddle here : http://jsfiddle.net/NTWNn/ it looks like this :

var books = [
    {
        title: "Inheritance: Inheritance Cycle, Book 4",
        author: "Christopher Paolini",
    },
    {
        title: "The Sense of an Ending",
        author: "Julian Barnes"
    },
    {
        title: "Snuff Discworld Novel 39",
        author: "Sir Terry Pratchett",
    }
]
search = prompt("Title?");

functioncount(pattern)
{
    var results = [];
    var matches = null;
    pattern = newRegExp(pattern, "g")

    for (i = 0; i < books.length; i++) {
        results[i] = 0;
        matches = books[i].title.toLowerCase().match(pattern);
        if(matches != null) {
            results[i] = matches.length;
        }
    }
    return results
}

alert(count(search))